Skip to content

fix offline BS swap for express Run3#35373

Merged
cmsbuild merged 7 commits intocms-sw:masterfrom
mmusich:fixOfflineBSSwapForExpress
Sep 29, 2021
Merged

fix offline BS swap for express Run3#35373
cmsbuild merged 7 commits intocms-sw:masterfrom
mmusich:fixOfflineBSSwapForExpress

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 22, 2021 •
edited
Loading

PR description:

Address discussion at #35334 (comment).

PR validation:

Run successfully wf 138.2 with: runTheMatrix.py -l 138.2 -j 8 -t 4 and verified the configuration looks as it should:

$edmConfigDump step2_RAW2DIGI_L1Reco_RECO_DQM.py > dump.py
$more dump.py | grep -A 5 OnlineBeamSpotESProducer
process.BeamSpotESProducer = cms.ESProducer("OnlineBeamSpotESProducer",
    appendToDataLabel = cms.string(''),
    sigmaZThreshold = cms.double(2),
    timeThreshold = cms.int32(48)
)

$more dump.py | grep useTransientRecord
    useTransientRecord = cms.bool(True)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but a backport to 12_0_X is needed.

@cmsbuild cmsbuild added this to the CMSSW_12_1_X milestone Sep 22, 2021
@mmusich mmusich mentioned this pull request Sep 22, 2021
Merged
@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2021

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 22, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35373/25451

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 22, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)
  • RecoVertex/BeamSpotProducer (reconstruction, alca)

@perrotta, @malbouis, @yuanchao, @davidlange6, @cmsbuild, @slava77, @jpata, @qliphy, @francescobrivio, @fabiocos, @tvami can you please review it and eventually sign? Thanks.
@fabiocos, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @tocheng, @mmusich, @mtosi, @dgulhan, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2021

please test

@mmusich mmusich mentioned this pull request Sep 22, 2021
Merged
@mmusich mmusich force-pushed the fixOfflineBSSwapForExpress branch from 3955f88 to 9bca3e1 Compare September 22, 2021 19:37
@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2021

I realized that the inclusion of

 BeamSpotESProducer = cms.ESProducer("OnlineBeamSpotESProducer")

in RecoVertex/BeamSpotProducer/python/BeamSpotOnline_cff.py is necessary to make the DQM unit tests to pass (see log)

@francescobrivio
Copy link
Contributor

francescobrivio commented Sep 22, 2021

@gennai @mzarucki I'm not sure how do you import the BeamSpotOnline ESProducer in the hlt menu, just be aware that the _cffand _cfi files are being modified here.

@francescobrivio
Copy link
Contributor

francescobrivio commented Sep 22, 2021

@mmusich is this still a draft?

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 22, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35373/25454

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@AdrianoDee
Copy link
Contributor

AdrianoDee commented Sep 28, 2021

+Upgrade

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 28, 2021

+1

@srimanob
Copy link
Contributor

srimanob commented Sep 28, 2021

+Upgrade

For the upgrade part, update to the defined GT on DD4hep.

@bbilin
Copy link
Contributor

bbilin commented Sep 28, 2021

+1

@qliphy
Copy link
Contributor

qliphy commented Sep 29, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 29, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 7001484 into cms-sw:master Sep 29, 2021
This was referenced Sep 29, 2021
Merged
Merged
Merged
@mmusich mmusich mentioned this pull request Sep 30, 2021
Merged
This was referenced Oct 3, 2021
Merged
Merged
@francescobrivio francescobrivio mentioned this pull request Oct 13, 2021
Closed
This was referenced Oct 13, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@slava77 slava77 slava77 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

alca-approved bug-fix code-checks-approved dqm-approved fully-signed operations-approved orp-approved pdmv-approved reconstruction-approved tests-approved upgrade-approved urgent

Projects

None yet

Milestone

CMSSW_12_1_X

Development

Successfully merging this pull request may close these issues.